fix: bake target names collision for services differing by '.' vs '_' - #14058
Merged
Conversation
glours
force-pushed
the
fix-bake-target-collision
branch
from
August 18, 2026 08:42
1038f8d to
08d11db
Compare
glours
approved these changes
Aug 18, 2026
ndeloof
force-pushed
the
fix-bake-target-collision
branch
from
August 18, 2026 09:13
08d11db to
1f14c8a
Compare
The dedup loop in bakeTargetNames checked whether the service already had a name — never true on first pass — instead of whether the name was already taken, so services like 'a.b' and 'a_b' silently mapped to the same bake target and one overwrote the other in the bake file. Allocate names in sorted service order (deterministic) and append '_' until unique. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
glours
approved these changes
Aug 18, 2026
ndeloof
force-pushed
the
fix-bake-target-collision
branch
from
August 18, 2026 09:23
1f14c8a to
b8e4a07
Compare
crazy-max
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Stacked on #14057.
The dedup loop in
bakeTargetNameschecked whether the service already had a name — never true on first pass — instead of whether the name was already taken, so services likea.banda_bsilently mapped to the same bake target and one overwrote the other in the bake file. Names are now allocated in sorted service order (deterministic) and a colliding name gets_appended until unique. Covered by a new unit test.Related issue
n/a
🤖 Generated with Claude Code