Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions .github/workflows/merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,10 @@ jobs:
type=ref,event=tag
type=edge
meta-bake-target: meta-helper
secrets:
registry-auths: |
- registry: docker.io
username: ${{ secrets.DOCKERPUBLICBOT_USERNAME }}
password: ${{ secrets.DOCKERPUBLICBOT_WRITE_PAT }}
registry-identities: |
- type: dockerhub
username: docker
connection_id: a295c8b7-54ab-4507-ac88-5c43003c73a5

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly question; will hard-coding it here cause it to always be non-empty, and forks attempting to use it (with a failure)?

(I'm guessing this workflow doesn't run on forks, so probably no difference; was just curious)


module-image:
uses: docker/github-builder/.github/workflows/bake.yml@27ade872c1e2296e62ef15ab3b10d37665e57cf7 # v1.15.0
Expand All @@ -74,10 +73,9 @@ jobs:
type=ref,event=branch
type=ref,event=tag
meta-bake-target: meta-helper
secrets:
registry-auths: |
- registry: docker.io
username: ${{ secrets.DOCKERPUBLICBOT_USERNAME }}
password: ${{ secrets.DOCKERPUBLICBOT_WRITE_PAT }}
registry-identities: |
- type: dockerhub
username: docker
connection_id: a295c8b7-54ab-4507-ac88-5c43003c73a5


Loading