Skip to content

Conversation

@idsulik
Copy link
Collaborator

@idsulik idsulik commented Nov 1, 2025

What I did
This PR resolves issue #13341 by automatically setting default model_var and endpoint_var values for services that use models but don't explicitly define these variables

Related issue
#13341

@idsulik idsulik requested a review from a team as a code owner November 1, 2025 20:59
@idsulik idsulik requested review from glours and ndeloof November 1, 2025 20:59
Copy link
Contributor

@ndeloof ndeloof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default values should be set by compose-go as we load a project IMHO

@idsulik
Copy link
Collaborator Author

idsulik commented Nov 3, 2025

@ndeloof but I'm not sure if it ok to make these changes for all places, because the documentation says only about environment values https://docs.docker.com/reference/compose-file/services/#models

If either is omitted, Compose automatically generates the environment variable names based on the model key using the following rules...

but in this PR I made the changes only for the converter, because it doesn't work even if you specify the environment values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants