remove API-version compatibility for API < v1.44 #6551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
impact/changelog
impact/deprecation
status/2-code-review
area/api
kind/refactor
thaJeztah
changed the title
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
thaJeztah
force-pushed
the
remove_legacy_api_versions
branch
2 times, most recently
from
6d4b033 to
8f7cc42
Compare
thaJeztah
force-pushed
the
remove_legacy_api_versions
branch
3 times, most recently
from
1ce0591 to
c939c9b
Compare
Support for API versions < v1.44 was removed in the client in [moby@96b29f5] and [moby@7652f38], so we can remove fallback-code from the CLI as well, as it won't be able to use those versions. [moby@96b29f5]: moby/moby@96b29f5 [moby@7652f38]: moby/moby@7652f38 Signed-off-by: Sebastiaan van Stijn <[email protected]>
This field is no longer in use since API v1.44. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This function was added in 7405ac5 as a fallback for API < v1.41, which did not include the service status in the response. Current API versions return this information, so there's no need to fetch it manually. It was not gated by API version for some tests (which didn't set API version), but should not be needed for non-test situations. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_legacy_api_versions
branch
from
c939c9b to
5ad9145
Compare
robmry
approved these changes
Oct 10, 2025
Member
Author
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to:
versions.*moby/moby#51086api/typesdo not relate to the Engine API moby/moby#50740remove API-version compatibility for API < v1.44
Support for API versions < v1.44 was removed in the client in moby@96b29f5
and moby@7652f38, so we can remove fallback-code from the CLI as well,
as it won't be able to use those versions.
cli/command/container: rm use of deprecated MacAddress field
This field is no longer in use since API v1.44.
cli/command/service: remove AppendServiceStatus (API <v1.41)
This function was added in 7405ac5 as
a fallback for API < v1.41, which did not include the service status
in the response. Current API versions return this information, so there's
no need to fetch it manually.
It was not gated by API version for some tests (which didn't set API
version), but should not be needed for non-test situations.
cli/command/container, image: remove addPlatformFlag utility
It was created for api-version conditionally setting the flag options.
docs: update some versions in examples
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)