cli/command/container: remove localhostDNSWarning #6535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
kind/refactor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This warning is better handled by the daemon, where applicable, as the client does not have all information available to determine if using a localhost / loopback-address for the DNS is possible. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_localhostDNSWarning
branch
from
e6f1ebc to
c06c085
Compare
5 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR removes client-side localhost DNS validation and warnings for container creation, delegating this responsibility to the daemon which has better context to determine if localhost/loopback DNS addresses will work based on the container's networking configuration.
- Removes the
localhostDNSWarningfunction from the CLI client - Eliminates client-side DNS validation for localhost/loopback addresses
- Removes associated test cases and golden test files
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cli/command/container/create.go | Removes DNS validation logic and function |
| cli/command/container/create_test.go | Removes test cases for localhost DNS warnings |
| cli/command/container/testdata/container-create-localhost-dns.golden | Removes expected warning output for IPv4 localhost DNS |
| cli/command/container/testdata/container-create-localhost-dns-ipv6.golden | Removes expected warning output for IPv6 localhost DNS |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
austinvazquez
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning is better handled by the daemon, where applicable, as the client does not have all information available to determine if using a localhost / loopback-address for the DNS is possible.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)