remove uses of cli.DefaultVersion() #5908
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
kind/refactor
thaJeztah
commented
Mar 8, 2025
Comment on lines
-91
to
92
| // DefaultVersion returns api.defaultVersion. | ||
| // DefaultVersion returns [api.DefaultVersion]. | ||
| func (*DockerCli) DefaultVersion() string { |
There was a problem hiding this comment.
We can probably deprecate as well
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5908 +/- ##
=======================================
Coverage 59.26% 59.26%
=======================================
Files 357 357
Lines 29771 29771
=======================================
Hits 17645 17645
Misses 11153 11153
Partials 973 973 🚀 New features to boost your workflow:
|
It's hard-coded to the API defaultversion, so we can use that const directly. Ultimately, this should be something returned by the API client configured on the CLI, not the CLI itself. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
client_api_version
branch
from
11a8049 to
79c9c7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's hard-coded to the API defaultversion, so we can use that const directly. Ultimately, this should be something returned by the API client configured on the CLI, not the CLI itself.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)