Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: remove deprecated Errors type #5549

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Oct 19, 2024

cli: remove deprecated Errors type

The Errors type was deprecated in d3bafa5,
which has been included in the 27.4.0 release.

This patch removes the type, as there are no external consumers.

- Description for the changelog

- go-sdk: remove deprecated `cli.Errors` type

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added impact/changelog impact/deprecation status/2-code-review area/go-sdk Changes affecting the Go SDK impact/go-sdk Noteworthy (compatibility changes) in the Go SDK labels Oct 19, 2024
@thaJeztah thaJeztah added this to the 28.0.0 milestone Oct 19, 2024
@thaJeztah thaJeztah self-assigned this Oct 19, 2024
@thaJeztah thaJeztah changed the title Remove cli errors cli: remove deprecated Errors type Oct 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.58%. Comparing base (1aab64d) to head (5f4b149).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5549      +/-   ##
==========================================
+ Coverage   59.16%   59.58%   +0.42%     
==========================================
  Files         342      345       +3     
  Lines       29092    29094       +2     
==========================================
+ Hits        17211    17335     +124     
+ Misses      10906    10787     -119     
+ Partials      975      972       -3     

The Errors type was deprecated in d3bafa5,
which has been included in the 27.4.0 release.

This patch removes the type, as there are no external consumers.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah marked this pull request as ready for review October 22, 2024 08:43
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@thaJeztah thaJeztah merged commit ea511f0 into docker:master Oct 22, 2024
89 checks passed
@thaJeztah thaJeztah deleted the remove_cli_errors branch October 22, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/go-sdk Changes affecting the Go SDK impact/changelog impact/deprecation impact/go-sdk Noteworthy (compatibility changes) in the Go SDK status/2-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants