feat: run and pull image completion from hub
#5528
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alano Terblanche <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5528 +/- ##
==========================================
- Coverage 60.67% 60.47% -0.21%
==========================================
Files 345 345
Lines 23488 23570 +82
==========================================
+ Hits 14252 14253 +1
- Misses 8263 8344 +81
Partials 973 973 |
Signed-off-by: Alano Terblanche <[email protected]>
Benehiko
force-pushed
the
hub-completions
branch
from
8511401
to
5760a3d
Compare
Benehiko
commented
Oct 11, 2024
cli/command/completion/functions.go
Outdated
|
|
||
| req, err := http.NewRequestWithContext(ctx, http.MethodGet, u.String(), nil) | ||
| if err != nil { | ||
| logrus.Errorf("Error creating hub image tags request: %v", err) |
There was a problem hiding this comment.
I honestly don't know what the best way would be for us to track errors for the completions. Maybe we should write debug logs to a file?
Signed-off-by: Alano Terblanche <[email protected]>
Signed-off-by: Alano Terblanche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Cobra completions using the Docker Hub v3 image search API.
The API is proxied through the docker engine: moby/moby#48692
Completion of images when calling
docker run/pullfrom local images and Docker Hub.Allows for image search based on partial matches. Also allows image tag search when adding
:after the image name.- How I did it
- How to verify it
Setup completion file https://docs.docker.com/engine/cli/completion/
docker completion <fish|bash|zsh> > <completion file>docker run [tab][tab]docker run postg[tab][tab]docker run postgres:[tab][tab]docker run postgres:alpine[tab][tab]- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)