lint: replace deprecated linter names #5298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`megacheck` has been deprecated/split into `gosimple`, `staticcheck`, and `unused`, which we're already using. https://github.com/golangci/golangci-lint/blob/d2b439faa53bc7d0645049c3e23fc858736b8cc4/pkg/lint/lintersdb/validator_test.go#L227 `vet` is now `govet`. https://github.com/golangci/golangci-lint/blame/d2b439faa53bc7d0645049c3e23fc858736b8cc4/pkg/lint/lintersdb/validator_test.go#L228 For more context, see: golangci/golangci-lint#4562 Signed-off-by: Laura Brehm <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5298 +/- ##
==========================================
- Coverage 61.45% 61.00% -0.46%
==========================================
Files 299 296 -3
Lines 20856 20848 -8
==========================================
- Hits 12818 12718 -100
- Misses 7122 7212 +90
- Partials 916 918 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Got tired of my lsp complaining, so I fixed up our
.golangci.yml:megacheckhas been deprecated/split intogosimple,staticcheck,and
unused, which we're already using – linkvetis nowgovet- linkFor more context, see: golangci/golangci-lint#4562
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)