-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate legacy image formats #4938
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
reviewed
Mar 12, 2024
thaJeztah
force-pushed
the
deprecate_legacy_images
branch
from
March 12, 2024 10:36
3cbad74
to
16300a8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4938 +/- ##
=======================================
Coverage 61.42% 61.43%
=======================================
Files 289 289
Lines 20237 20237
=======================================
+ Hits 12431 12433 +2
+ Misses 6904 6903 -1
+ Partials 902 901 -1 |
thaJeztah
commented
Mar 12, 2024
thaJeztah
force-pushed
the
deprecate_legacy_images
branch
from
March 12, 2024 10:39
16300a8
to
f21c361
Compare
vvoland
approved these changes
Mar 12, 2024
dvdksn
reviewed
Mar 12, 2024
thaJeztah
force-pushed
the
deprecate_legacy_images
branch
from
March 12, 2024 15:37
f21c361
to
83f9ed7
Compare
dvdksn
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dvdksn
reviewed
Mar 12, 2024
Mark pulling legacy image formats as deprecated, and describe the DOCKER_ENABLE_DEPRECATED_PULL_SCHEMA_1_IMAGE environment variable. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
deprecate_legacy_images
branch
from
March 12, 2024 16:20
83f9ed7
to
90c33db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark pulling legacy image formats as deprecated, and describe the DOCKER_ENABLE_DEPRECATED_PULL_SCHEMA_1_IMAGE environment variable.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)