Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where incorrect response is returned #3845

Closed
wants to merge 1 commit into from
Closed

Fix bug where incorrect response is returned #3845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmd/docker/docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package main

import (
"context"
"fmt"
"os"
"os/exec"
Expand Down Expand Up @@ -374,8 +375,12 @@ func findCommand(cmd *cobra.Command, commands []string) bool {
return findCommand(cmd.Parent(), commands)
}

func isSupported(cmd *cobra.Command, details versionDetails) error {
func isSupported(cmd *cobra.Command, details command.Cli) error {
if err := areSubcommandsSupported(cmd, details); err != nil {
// Check if the command not being supported is due to Ping failing
if _, connectError := details.Client().Ping(context.Background()); connectError != nil {
return connectError
}
return err
}
return areFlagsSupported(cmd, details)
Expand Down