add --signal option to stop and restart #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wording and documentation still need to be updated, but will do so in a follow-up. Also removing the default "10 seconds" from the timeout flags, as this default is not actually used, and may not match the actual default (which is defined on the daemon side). Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
I have a branch with "WIP" documentation changes, and changes to the completion scripts, but will push that as a follow-up pull request (some more work needed). |
Codecov Report
@@ Coverage Diff @@
## master #3614 +/- ##
==========================================
- Coverage 58.96% 58.96% -0.01%
==========================================
Files 288 288
Lines 24421 24425 +4
==========================================
Hits 14401 14401
- Misses 9148 9152 +4
Partials 872 872 |
ndeloof
approved these changes
May 17, 2022
rumpl
approved these changes
May 17, 2022
matt9ucci
added a commit
to matt9ucci/DockerCompletion
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wording and documentation still need to be updated, but will do
so in a follow-up.
Also removing the default "10 seconds" from the timeout flags, as
this default is not actually used, and may not match the actual
default (which is defined on the daemon side).
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)