Service privileges: CLI reference docs & completion #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Also ping @albers PTAL |
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
==========================================
+ Coverage 48.83% 48.85% +0.01%
==========================================
Files 186 186
Lines 12413 12413
==========================================
+ Hits 6062 6064 +2
+ Misses 5977 5975 -2
Partials 374 374 |
johnstep
suggested changes
Jul 15, 2017
| For example, specifying `file://spec.json` loads | ||
| `C:\ProgramData\Docker\CredentialSpecs\spec.json`. | ||
|
|
||
| When using the `registry://keyname` format, the credential spec is read |
Contributor
There was a problem hiding this comment.
Remove keyname here since this only needs to state the prefix (and, technically, it is a value not a key).
Member
Author
There was a problem hiding this comment.
Darn, copied the wrong one; I can make it registry://<value name>
| When using the `registry://keyname` format, the credential spec is read | ||
| from the Windows registry on the daemon's host. The specified registry | ||
| value must be located in `HKLM\SOFTWARE\Microsoft\Windows | ||
| NT\CurrentVersion\Virtualization\Containers\CredentialSpecs`. |
Contributor
There was a problem hiding this comment.
There should be a space between Windows and NT. Is that going to be clear?
Member
Author
There was a problem hiding this comment.
oh, I see it wrapped; hold on, fixing
thaJeztah
force-pushed
the
carry-moby-32483
branch
from
ebf01c1 to
214d04d
Compare
Member
Author
|
Updated, PTAL |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
carry-moby-32483
branch
from
214d04d to
5cc7ac2
Compare
Member
Author
|
author LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the Service privileges API changes, that were added in: moby/moby@091b5e6 (moby/moby#32339)
Carries the CLI changes of moby/moby#32483, with some additional information about the values
ping @johnstep PTAL