-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shorthand for --tail option #2646
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2646 +/- ##
=======================================
Coverage 58.13% 58.13%
=======================================
Files 295 295
Lines 21194 21194
=======================================
Hits 12321 12321
Misses 7966 7966
Partials 907 907 |
I chose -n shorthand as it's similar with linux `tail` command. Signed-off-by: Александр Менщиков <[email protected]>
Thanks for contributing ; I'm ok with this change (name is consistent with Could you also;
Let me know if you need help with that |
963e16c
to
e1a2e16
Compare
Signed-off-by: horpto <[email protected]>
@thaJeztah thanks for reply. I found other place with logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completion LGTM, thanks for the contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thank you!
@cpuguy83 @silvin-lubecki looking good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @horpto 👍
Let's get this one merged 👍 |
I chose -n shorthand as it's similar with linux
tail
command.- What I did
- How I did it
- How to verify it
- Description for the changelog
Add shorthand
-n
for --tail option- A picture of a cute animal (not mandatory but encouraged)