[v0.28] cherry-picks for v0.28.0 #3400
Conversation
| } | ||
| if st.Code() == codes.Unimplemented && strings.Contains(st.Message(), "unsupported frontend capability moby.buildkit.frontend.gitquerystring") { | ||
| msg := "current frontend does not support Git URLs with query string components." | ||
| msg += " Git URLs with query string are supported since Dockerfile v1.18 and BuildKit v0.24. Use BUILDKIT_SYNTAX build-arg, #syntax directive in Dockerfile or update to latest BuildKit." |
There was a problem hiding this comment.
Does this require both the updated frontend and latest BuildKit, or is updating the frontend sufficient? The error is a bit ambiguous (using an older frontend with BuildKit v0.24 would still fail I guess? But not sure if just updating the syntax would fix that).
Recommending users to update to latest BuildKit also won't work if this error is returned from the default builder in dockerd; perhaps we should have a /go/ link to the Dockerfile syntax directive (which could link to alternatives such as the BUILDKIT_SYNTAX.
There was a problem hiding this comment.
perhaps we should have a
/go/link to the Dockerfile syntax directive (which could link to alternatives such as theBUILDKIT_SYNTAX.
Do you mean a /go link in the error message with more information? Was thinking of putting some of these use cases https://github.com/crazy-max/buildx-buildkit-tests/tree/main/buildkit-6178#readme along docker/docs#23322
There was a problem hiding this comment.
Yes, was considering a https://docs.docker.com/go/.... URL in the error; mostly because it's probably too much to describe all possible options in the error itself, and I could see # syntax= could be useful to reference in some places (not everyone is familiar with them yet).
There was a problem hiding this comment.
Yeah that makes sense. I discussed with @tonistiigi, we will create a /go page on docs website but will do after this release as we can't publish the docs page before DD release. Fyi, made some changes in docker/docs#23322.
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
crazy-max
force-pushed
the
v0.28_picks_0.28.0
branch
from
7f50cbe to
101403b
Compare
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
v0.28_picks_0.28.0
branch
from
101403b to
db10f5f
Compare
3 participants
backport of: