progress: invoke onclose every time display is stopped #3246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the refactor, it was changed to only call `onclose` when the printer itself was closed. The original version invoked this when the display was stopped in anyway. Changing this back to see if it fixes a display issue that's popped up with the refactor. Restores the metric writer which accidentally got left off in the refactor and wasn't noticed. Signed-off-by: Jonathan A. Sternberg <[email protected]>
Collaborator
Author
|
This wasn't the cause of the issue. We found the real cause and it's fixed here: #3248 The extra stuff in this PR such as the metric writer have been moved to that PR instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the refactor, it was changed to only call
onclosewhen theprinter itself was closed. The original version invoked this when the
display was stopped in anyway.
Changing this back to see if it fixes a display issue that's popped up
with the refactor.
Restores the metric writer which accidentally got left off in the
refactor and wasn't noticed.