Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to go 1.23 #2782

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

update to go 1.23 #2782

wants to merge 4 commits into from
+20 −18

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max added this to the v0.19.0 milestone Nov 7, 2024
@crazy-max
update to go 1.23
0a65ff9 
Signed-off-by: CrazyMax <[email protected]>
@crazy-max crazy-max changed the title update go to 1.23 update to go 1.23 Nov 7, 2024
@crazy-max crazy-max mentioned this pull request Nov 7, 2024
Draft
@crazy-max crazy-max marked this pull request as ready for review November 7, 2024 13:07
@thaJeztah
Copy link
Member

Can you update the order of the commits?

  • The fix golangci-lint issues should probably be first
  • then the "update golangci", and then the other ones.
  • oh, and the G115 # integer overflow conversion (TODO: verify these) should be in the second one (as it's related to the golangci-lint update)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi Awaiting requested review from tonistiigi

@jsternberg jsternberg Awaiting requested review from jsternberg

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

At least 1 approving review is required to merge this pull request.

Assignees

@tonistiigi tonistiigi

@crazy-max crazy-max

Labels
area/ci area/driver/docker area/driver area/hack
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@crazy-max @thaJeztah @tonistiigi