-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bake: initial set of composable bake attributes #2758
base: master
Are you sure you want to change the base?
Conversation
Very incomplete first draft. This requires some changes to the The only changes to |
2a36f74
to
88ff1f4
Compare
88ff1f4
to
4e0ecda
Compare
ceecb9d
to
af7ebbf
Compare
95dc438
to
3f474cc
Compare
I've modified this to include a small fork of the |
3f474cc
to
6947951
Compare
https://github.com/docker/buildx/blob/master/bake/hclparser/merged.go is also a fork from upstream. Maybe we could move it to an
|
6b42716
to
5f76a38
Compare
This allows using either the csv syntax or object syntax to specify certain attributes. This applies to the following fields: - output - cache-from - cache-to - secret - ssh There are still some remaining fields to translate. Specifically ulimits, annotations, and attest. Signed-off-by: Jonathan A. Sternberg <[email protected]>
5f76a38
to
0ac54d6
Compare
This PR is becoming fairly large. There are a few more attributes that have to be migrated to work, but it might be good to review and merge what we have to land this feature. I'm changing this to ready to review while I work on the remaining attributes. |
0ac54d6
to
1ed12f2
Compare
dcf5387
to
0ac54d6
Compare
This allows using either the csv syntax or object syntax to specify
certain attributes.
This applies to the following fields:
There are still some remaining fields to translate. Specifically
ulimits, annotations, and attest.
Related to #438.