e2e: load to docker store#1460
Merged
crazy-max merged 1 commit intodocker:masterfrom Dec 15, 2022
Merged
Conversation
Member
Author
@jedevc I think we need changes here to properly handle multi-platform for OCI exporter like we do for the image one. |
Collaborator
|
@crazy-max I think this should be solved by moby/buildkit#3380. It's a result of buildx attempting to attach provenance attestations by default, but, we need to filter out the inline attestations for the docker exporter just like we do for the local and tar exporter. |
Member
Author
|
@jedevc Nice, didn't catch that PR. |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
2e0a074 to
99ac7f5
Compare
jedevc
approved these changes
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com