bake(compose): fix unskipped services without build context #1277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1276
while fixing compose consistency check in #1181 a regression was introduced where services without build context were taken into account.
it was not detected because our test
TestNoBuildOutOfTreeService
was not checking the targets length:buildx/bake/compose_test.go
Lines 71 to 82 in 611329f
by fixing this issue we now remove the ability to merge compose files without a build context #1172. To fix this we now parse compose files all together so the compose-go library can handle a proper sanity check on its side.
Signed-off-by: CrazyMax [email protected]