Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update buildkit to 0.19.0 and buildx to 0.20.1 #572

Merged
merged 4 commits into from
Jan 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ on:
env:
NODE_VERSION: "20"
BUILDX_VERSION: "edge"
BUILDKIT_IMAGE: "moby/buildkit:v0.18.2"
BUILDKIT_IMAGE: "moby/buildkit:v0.19.0"

jobs:
test:
Expand Down
9 changes: 8 additions & 1 deletion __tests__/.fixtures/bake-03-default.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
{
"group": {
"default": {
"targets": [
"default"
]
}
},
"target": {
"default": {
"context": ".",
Expand All @@ -9,7 +16,7 @@
"type": "provenance"
},
{
"disabled": "true",
"disabled": true,
"type": "sbom"
}
],
Expand Down
2 changes: 1 addition & 1 deletion dev.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

ARG NODE_VERSION=20
ARG DOCKER_VERSION=27.2.1
ARG BUILDX_VERSION=0.19.3
ARG BUILDX_VERSION=0.20.1
ARG COMPOSE_VERSION=2.32.4
ARG UNDOCK_VERSION=0.8.0

Expand Down
3 changes: 3 additions & 0 deletions src/buildx/bake.ts
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,9 @@ export class Bake {
case 'type':
attestEntry.type = value;
break;
case 'disabled':
attestEntry.disabled = Util.parseBool(value);
break;
default:
attestEntry[key] = value;
}
Expand Down
3 changes: 2 additions & 1 deletion src/types/buildx/bake.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ export interface Target {

export interface AttestEntry {
type: string;
[key: string]: string;
disabled?: string | boolean;
[key: string]: string | boolean | undefined;
}

export interface CacheEntry {
Expand Down
Loading