Skip upstream openjdk entrypoint#303
Merged
yosifkit merged 1 commit intodocker-library:masterfrom Aug 11, 2023
Merged
Conversation
The upstream entrypoint is `sh` and so loses dotted environment variables, lets prevent that from happening by just skipping it as the `tomcat` images are not reliant on its functionality. See docker-library/docs#2338 and adoptium/containers#392 for info about what it provides. Fixes docker-library#302 which is a recurrence of docker-library#77
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Aug 11, 2023
Changes: - docker-library/tomcat@18d7f71: Merge pull request docker-library/tomcat#303 from infosiftr/fix-77-again - docker-library/tomcat@55546d6: Skip upstream openjdk entrypoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream entrypoint is
shand so loses dotted environment variables, lets prevent that from happening by just skipping it as thetomcatimages are not reliant on its functionality. See docker-library/docs#2338 and adoptium/containers#392 for info about what it provides.Fixes #302 which is a recurrence of #77