Add check to naughty-commits to ensure that referenced commit exists in the upstream#11071
Merged
tianon merged 1 commit intodocker-library:masterfrom Oct 8, 2021
Merged
Conversation
tianon
reviewed
Oct 8, 2021
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
A few minor style nits, but overall I like it 💪
Merged
yosifkit
force-pushed
the
enforce-gitfetch
branch
from
e3ccec4 to
32ec62b
Compare
…in the upstream GitFetch branch Also update single-line library files to rfc2822 format to avoid 'refs/heads/*'
yosifkit
force-pushed
the
enforce-gitfetch
branch
from
32ec62b to
a6b189f
Compare
Diff for a6b189f:diff --git a/_bashbrew-cat b/_bashbrew-cat
index c6d9a91..5d20376 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -1,33 +1,29 @@
# sourcemage
Maintainers: Vlad Glagolev <stealth@sourcemage.org> (@vaygr)
-GitFetch: refs/heads/*
+GitRepo: git://github.com/vaygr/docker-sourcemage
+GitFetch: refs/heads/dist-stable
Tags: latest, 0.62
-GitRepo: git://github.com/vaygr/docker-sourcemage
GitCommit: a03bbe3ae7bbb839c3c69afd4504ca336f7b9cb9
Directory: stable
# thrift
Maintainers: Adam Hawkins <hi@ahawkins.me> (@ahawkins)
-GitFetch: refs/heads/*
+GitRepo: git://github.com/ahawkins/docker-thrift
Tags: 0.9, 0.9.3
-GitRepo: git://github.com/ahawkins/docker-thrift
GitCommit: d322572f7dd6ea468a14a4d832fbec26f152c71e
Directory: 0.9
Tags: 0.10, 0.10.0
-GitRepo: git://github.com/ahawkins/docker-thrift
GitCommit: e1f81dfe3e8fac5588e12d2b880166d1743dbecd
Directory: 0.10
Tags: 0.11, 0.11.0
-GitRepo: git://github.com/ahawkins/docker-thrift
GitCommit: 00e197d889426695446baec4e034b5ddbb15bcb3
Directory: 0.11
Tags: 0.12, 0.12.0, latest
-GitRepo: git://github.com/ahawkins/docker-thrift
GitCommit: d7e73876549d205898b1922bcbf69e74ef11c288
Directory: 0.12
diff --git a/_bashbrew.err b/_bashbrew.err
index 0b333ea..e69de29 100644
--- a/_bashbrew.err
+++ b/_bashbrew.err
@@ -1,5 +0,0 @@
-warning: insecure protocol git:// detected: git://github.com/vaygr/docker-sourcemage
-warning: insecure protocol git:// detected: git://github.com/ahawkins/docker-thrift
-warning: insecure protocol git:// detected: git://github.com/ahawkins/docker-thrift
-warning: insecure protocol git:// detected: git://github.com/ahawkins/docker-thrift
-warning: insecure protocol git:// detected: git://github.com/ahawkins/docker-thrift
|
This was referenced Oct 8, 2021
Merged
9 tasks
This was referenced Nov 18, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the
GitFetchbranch to ensure that the commit does not come from outside the upstream repo. This will cause a few images to need to set a defaultGitFetchsince they use a branch other thanmaster.Also update the last single-line-format library files (
sourcemageandthrift) to rfc2822 format to avoidrefs/heads/*; should either of these just be emptied since they are deprecated? (docker-library/docs#1433 and docker-library/docs#1732)current output: