Update EG to 1.16.11 #10105
Merged
Update EG to 1.16.11 #10105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosifkit
reviewed
May 3, 2021
library/express-gateway
Outdated
| @@ -1,7 +1,7 @@ | |||
| Maintainers: The Express-Gateway Team <[email protected]> (@express_gateway) | |||
| GitRepo: https://github.com/ExpressGateway/docker-express-gateway.git | |||
|
|
|||
| Tags: 1.x, 1.16.x, 1.16.10, latest | |||
| Tags: 1.x, 1.16.x, 1.16.11, latest | |||
| Architectures: arm64v8, amd64, i386, ppc64le, s390x | |||
There was a problem hiding this comment.
It seems that node images don't have i386 support anymore. (cause of GitHub Actions failure)
Edit: link to related node issue: nodejs/docker-node#1344
Diff for e0f1679:diff --git a/_bashbrew-cat b/_bashbrew-cat
index 6aeb523..87fdb5e 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -1,7 +1,7 @@
Maintainers: The Express-Gateway Team <[email protected]> (@express_gateway)
GitRepo: https://github.com/ExpressGateway/docker-express-gateway.git
-Tags: 1.x, 1.16.x, 1.16.10, latest
-Architectures: amd64, arm64v8, i386, ppc64le, s390x
-GitCommit: 704432298a3b9a99de87fcb19b33962e6995b7a3
+Tags: 1.x, 1.16.x, 1.16.11, latest
+Architectures: amd64, arm64v8, ppc64le, s390x
+GitCommit: fa2707c3b24bbd99710a100d7859566fa28817b8
Directory: alpine
diff --git a/_bashbrew-list b/_bashbrew-list
index 9af43a4..d4b3155 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -1,4 +1,4 @@
express-gateway:1.x
express-gateway:1.16.x
-express-gateway:1.16.10
+express-gateway:1.16.11
express-gateway:latest
diff --git a/express-gateway_latest/Dockerfile b/express-gateway_latest/Dockerfile
index 308bbdd..7221b4e 100644
--- a/express-gateway_latest/Dockerfile
+++ b/express-gateway_latest/Dockerfile
@@ -1,8 +1,8 @@
-FROM node:10-alpine
+FROM node:12-alpine
LABEL maintainer Vincenzo Chianese, [email protected]
-ARG EG_VERSION=1.16.10
+ARG EG_VERSION=1.16.11
RUN yarn global add express-gateway@$EG_VERSION && yarn cache clean
|
|
Thanks for the quick responses! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also changes the base imge to node 12