Allow arbitrary --user values #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to https://www.mysql.com/support/eol-notice.html, we might technically be able to drop 5.5 as EOL as of today (although we're running it on Debian 7, which never was actually supported), but since it was pretty simple to make it work too, I just went for it. |
|
5.5 is actually pretty nice to have in that upstream doesn't actually provide Debian/Ubuntu packages for it, so I'd think the ease of use/setup of the Docker image is a pretty big plus (though I have no usage numbers to back this up with :P) |
|
Fair enough! 👍
|
|
Oh, and change generally looks good to me, though I have to admit I haven't looked closely at gosu :) |
|
It's conceptually really simple -- like |
|
I think the main difference is that the |
|
LGTM. Should we merge? |
|
Yeah, I think we can. |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
May 16, 2016
- `cassandra`: 3.0.6 - `mongo`: 3.3.6 - `mysql`: allow arbitrary `--user` (docker-library/mysql#161) - `owncloud`: 8.2.5, 8.1.8, 8.0.13, 7.0.15 - `tomcat`: 9.0.0.M6, 8.5.2, 8.0.35
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
May 17, 2016
- `cassandra`: 3.0.6 - `mongo`: 3.3.6 - `mysql`: allow arbitrary `--user` (docker-library/mysql#161) - `owncloud`: 8.2.5, 8.1.8, 8.0.13, 7.0.15 - `tomcat`: 9.0.0.M6, 8.5.2, 8.0.35
This was referenced May 17, 2016
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
- `cassandra`: 3.0.6 - `mongo`: 3.3.6 - `mysql`: allow arbitrary `--user` (docker-library/mysql#161) - `owncloud`: 8.2.5, 8.1.8, 8.0.13, 7.0.15 - `tomcat`: 9.0.0.M6, 8.5.2, 8.0.35
Closed
This was referenced Jan 19, 2017
This was referenced Dec 21, 2017
9 tasks
This was referenced Feb 12, 2018
This was referenced Nov 1, 2018
lag-linaro
pushed a commit
to lag-linaro/fluentd-docker-image
that referenced
this pull request
Nov 16, 2018
If permissions problems exist, they should be overcome properly. For examples see: LINK: docker-library/rabbitmq#60 LINK: docker-library/cassandra#48 LINK: docker-library/mongo#81 LINK: redis/docker-library-redis#48 LINK: docker-library/mysql#161 LINK: MariaDB/mariadb-docker#59 LINK: docker-library/percona#21 LINK: docker-library/ghost#54 LINK: docker-library/postgres#253 As suggested by @tianon LINK: docker-library/official-images#3724 (comment) This is part of an effort to make FluentD part of Docker's Official Images. Signed-off-by: Lee Jones <[email protected]>
lag-linaro
pushed a commit
to lag-linaro/fluentd-docker-image
that referenced
this pull request
Nov 19, 2018
If permissions problems exist, they should be overcome properly. For examples see: LINK: docker-library/rabbitmq#60 LINK: docker-library/cassandra#48 LINK: docker-library/mongo#81 LINK: redis/docker-library-redis#48 LINK: docker-library/mysql#161 LINK: MariaDB/mariadb-docker#59 LINK: docker-library/percona#21 LINK: docker-library/ghost#54 LINK: docker-library/postgres#253 As suggested by @tianon LINK: docker-library/official-images#3724 (comment) This is part of an effort to make FluentD part of Docker's Official Images. Signed-off-by: Lee Jones <[email protected]>
lag-linaro
pushed a commit
to lag-linaro/fluentd-docker-image
that referenced
this pull request
Nov 23, 2018
If permissions problems exist, they should be overcome properly. For examples see: LINK: docker-library/rabbitmq#60 LINK: docker-library/cassandra#48 LINK: docker-library/mongo#81 LINK: redis/docker-library-redis#48 LINK: docker-library/mysql#161 LINK: MariaDB/mariadb-docker#59 LINK: docker-library/percona#21 LINK: docker-library/ghost#54 LINK: docker-library/postgres#253 As suggested by @tianon LINK: docker-library/official-images#3724 (comment) This is part of an effort to make FluentD part of Docker's Official Images. Signed-off-by: Lee Jones <[email protected]>
lag-linaro
pushed a commit
to lag-linaro/fluentd-docker-image
that referenced
this pull request
Nov 30, 2018
If permissions problems exist, they should be overcome properly. For examples see: LINK: docker-library/rabbitmq#60 LINK: docker-library/cassandra#48 LINK: docker-library/mongo#81 LINK: redis/docker-library-redis#48 LINK: docker-library/mysql#161 LINK: MariaDB/mariadb-docker#59 LINK: docker-library/percona#21 LINK: docker-library/ghost#54 LINK: docker-library/postgres#253 As suggested by @tianon LINK: docker-library/official-images#3724 (comment) This is part of an effort to make FluentD part of Docker's Official Images. Signed-off-by: Lee Jones <[email protected]>
lag-linaro
pushed a commit
to lag-linaro/fluentd-docker-image
that referenced
this pull request
Dec 19, 2018
If permissions problems exist, they should be overcome properly. For examples see: LINK: docker-library/rabbitmq#60 LINK: docker-library/cassandra#48 LINK: docker-library/mongo#81 LINK: redis/docker-library-redis#48 LINK: docker-library/mysql#161 LINK: MariaDB/mariadb-docker#59 LINK: docker-library/percona#21 LINK: docker-library/ghost#54 LINK: docker-library/postgres#253 As suggested by @tianon LINK: docker-library/official-images#3724 (comment) This is part of an effort to make FluentD part of Docker's Official Images. Signed-off-by: Lee Jones <[email protected]>
grooverdan
referenced
this pull request
in MariaDB/mariadb-docker
Dec 6, 2021
Report was:
In docker-entrypoint.sh line 67:
mysql=( docker_process_sql )
^---^ SC2034: mysql appears unused. Verify use (or export if used externally).
In docker-entrypoint.sh line 81:
. "$f"
^--^ SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.
In docker-entrypoint.sh line 149:
if [ -z "$MARIADB_ROOT_PASSWORD" -a -z "$MARIADB_ALLOW_EMPTY_ROOT_PASSWORD" -a -z "$MARIADB_RANDOM_ROOT_PASSWORD" ]; then
^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
In docker-entrypoint.sh line 228:
passfileArgs=()
^----------^ SC2034: passfileArgs appears unused. Verify use (or export if used externally).
In docker-entrypoint.sh line 231:
MYSQL_PWD= docker_exec_client "$@"
^-- SC1007: Remove space after = if trying to assign a value (for empty string, use var='' ... ).
In docker-entrypoint.sh line 366:
exec gosu mysql "$BASH_SOURCE" "$@"
^----------^ SC2128: Expanding an array without an index only gives the first element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #153
See also docker-library/rabbitmq#60, docker-library/cassandra#48, docker-library/mongo#81, and redis/docker-library-redis#48.
cc @ltangvald