Fix line endings on Windows with gitattributes #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosifkit
approved these changes
Sep 30, 2020
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Feb 23, 2021
Changes: - docker-library/hello-world@a6fdcbf: Add "ltsc2019" tag to example Windows one-liner (docker-library/hello-world#85) - docker-library/hello-world@92f8ec3: Merge pull request docker-library/hello-world#80 from infosiftr/gitattributes - docker-library/hello-world@93e0c55: Fix line endings on Windows with gitattributes - docker-library/hello-world@9ef4804: Merge pull request docker-library/hello-world#73 from docker-library/github-actions - docker-library/hello-world@bf64724: Add initial GitHub Actions CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78
Tested successfully in an environment where I've set
git config --global core.autocrlf true(and thusdocker build --file Dockerfile.build https://github.com/docker-library/hello-world.gitfails), and I've confirmed thatdocker build --file Dockerfile.build https://github.com/infosiftr/hello-world.git#gitattributessucceeds.