Add Ghost 4 pre-release version #245
Conversation
|
@tianon just as a heads up - there might be more changes to the Ghost boot process prior to the official 4.0 release, so it might be worth holding off on releasing these until those changes are fully defined. The update to Ghost-CLI supporting prerelease installs hasn't been released yet either 😬 so this image won't be able to build until then anyways. |
|
I was just about to ping you with the Ghost-CLI failure that you're probably already aware of 😆 ❤️ |
This comment has been minimized.
This comment has been minimized.
4-rc/alpine/Dockerfile
Outdated
| mkdir -p "$GHOST_INSTALL"; \ | ||
| chown node:node "$GHOST_INSTALL"; \ | ||
| \ | ||
| su-exec node ghost install "$GHOST_VERSION" --db sqlite3 --no-prompt --no-stack --no-setup --dir "$GHOST_INSTALL"; \ |
There was a problem hiding this comment.
this should work now if you add --channel next to the arguments list
There was a problem hiding this comment.
I think I might've missed something because it's giving me Message: Version 4.0.0 does not exist 😅
(from ghost install 4.0.0-alpha.3 --channel next --db sqlite3 --no-prompt --no-stack --no-setup --dir /var/lib/ghost)
There was a problem hiding this comment.
hmm that does appear to be a bug. I never tested specifying the exact alpha release to install 😅 will test and try to get a fix out
There was a problem hiding this comment.
I wonder if it makes sense just to wait until 4.0 is officially released before creating the docker image?
There was a problem hiding this comment.
🤷 we're happy to go either way -- we like to publish pre-releases for the same reason the upstreams usually do (more users testing before GA, hopefully finding more bugs), but we're happy to defer 👍
There was a problem hiding this comment.
@tianon so it looks like the reason this fails is because semver.coerce() doesn't like prerelease versions 🤔 npm/node-semver#357
we currently run the version through semver.coerce and that strips the prerelease bit off of the version.
|
since ghost v4 has been released, gonna create a separate PR adding the v4 images here shortly |
|
this can be closed on account of #249 |
No description provided.