Skip to content

Run as non-root by default #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yosifkit merged 1 commit into from
Feb 23, 2015
Merged

Run as non-root by default #1

yosifkit merged 1 commit into from
Feb 23, 2015

Conversation

@tianon
Copy link
Member

@tianon tianon commented Feb 21, 2015

@md5 ❤️ (docker-library/official-images#505 (comment))

I'd much rather be non-root from the start than try to backpedal later.

@tianon
Copy link
Member Author

tianon commented Feb 21, 2015

npm start is the way upstream explains you should run, but I also see mention of node index.js being acceptable -- not sure which one we should standardize on 😕

@md5
Copy link
Contributor

md5 commented Feb 21, 2015

I would recommend using npm start. If they later decide to update the start script to something other than node index, they'll do it here: https://github.com/TryGhost/Ghost/blob/2a91a1071e4d4d7a5a4bfea971a77b6eed6a9349/package.json#L26

@yosifkit
Copy link
Member

yosifkit commented Feb 23, 2015

LGTM

@md5
Copy link
Contributor

md5 commented Feb 23, 2015

LGTM too.

yosifkit added a commit that referenced this pull request Feb 23, 2015
@yosifkit
Merge pull request #1 from infosiftr/non-root
f54e546 
Run as non-root by default
@yosifkit yosifkit merged commit f54e546 into docker-library:master Feb 23, 2015
@yosifkit yosifkit deleted the non-root branch February 23, 2015 19:17
@tianon
Copy link
Member Author

tianon commented Feb 23, 2015

❤️

@necevil necevil mentioned this pull request Dec 28, 2016
Closed
@pascalandy pascalandy mentioned this pull request Aug 17, 2017
Closed
@axeII axeII mentioned this pull request Oct 13, 2018
Closed
tianon pushed a commit that referenced this pull request Jan 8, 2025
@locohamster
Merge pull request #1 from locohamster/update-to-alpine3.21
ecd5118 
Update Dockerfile base image alpine3.20->alpine3.21
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jan 8, 2025
@docker-library-bot
Update ghost
ae6ed4b 
Changes:

- docker-library/ghost@51d8f68: Merge pull request docker-library/ghost#428 from locohamster/master
- docker-library/ghost@ecd5118: Merge pull request docker-library/ghost#1 from locohamster/update-to-alpine3.21
- docker-library/ghost@53b2329: Update Dockerfile base image alpine3.20->alpine3.21
@tianon tianon mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tianon @md5 @yosifkit