Update Dockerfile to install PHP zip extension

[skyred]

Drupal uses Composer a lot; especially Drupal 8, and there are a lot of modules, requiring composer, are being back ported to Drupal 7. Composer use PHP zip extension. Otherwise, see docker-library/php#60

[skyred]

When run

composer drupal-update

under Drupal/core/

It fails without php zip extension. So, we need php zip extension for Drupal 8.

[yosifkit]

With those backports, do you think it should also be added it to the drupal 7 image as well?

[skyred]

For D7, without Composer, the Core doesn't fail.

But, this is Composer Manager statistics https://www.drupal.org/project/usage/composer_manager

Currently, there are about 1,500 sites using Composer on D7. I expect this number to increase and more people to use docker. Therefore, I think it's a good idea to add PHP zip extension to D7 image.

[tianon]

Is Composer part of Drupal's core? I can't seem to find any mention of either composer or drush (which is the primary context I see mention of Composer+Drupal in my searching):

$ docker run -it --rm drupal bash
root@8f71ce34dd8d:/var/www/html# find -name '*drush*'
root@8f71ce34dd8d:/var/www/html# find -name '*composer*'
root@8f71ce34dd8d:/var/www/html# grep -rn 'composer' .
root@8f71ce34dd8d:/var/www/html# 

I think the argument that it's used by a majority of modules is compelling, but I want to make sure we don't rush into it. If it is indeed used directly by a compelling number of modules, we should likely add Composer itself to the base image as well, right?

[skyred]

D8 core ships with

./composer.json
./core/vendor/autoload.php

When people follow the instructions below

Workflow
Download the desired modules (such as Commerce).
Inside your core/ directory run  composer drupal-update.
This rebuilds core/composer.json and downloads the new module's requirements.
Install the modules.

https://www.drupal.org/node/2405811

This workflow will fail because of #7 (comment)

On the other hand, D7 core doesn't have files directly related to Composer

[skyred]

I'd like to point it out, if this image doesn't support php zip (therefore, composer digitalkaoz/composer@3862445)

The ways to install many D8 modules are:

1. Support Is a Volume Needed? #3, so we can spin up another container with Composer and use --volumes-from=THE_CONTAINER_BUILT_ON_THIS_IMAGE, then do Composer Update in the new container. I have written an example here https://github.com/INsReady/Data-SSH-Container
2. "docker exec -ti THE_CONTAINER_BUILT_ON_THIS_IMAGE bash", then install php zip extension

[bojanz]

Composer is here to stay, and will be the only way many modules (such as Commerce, Address) will be installable. It will also eventually replace Drush Make.

Not supporting Composer makes this solution unusable for Drupal 8, so I encourage this issue to move forward.

[yosifkit]

Sounds good to me. What do you think @tianon?

@skyred do you want to rebase this PR and apply to 7 as well?

[skyred]

As @yosifkit suggested in #7 (comment)

The updated patch is ready for your reviewing

[yosifkit]

LGTM

[tianon]

LGTM