Correct openliberty doc for server feature configuration#1863
Merged
tianon merged 6 commits intodocker-library:masterfrom Feb 17, 2021
Merged
Correct openliberty doc for server feature configuration#1863tianon merged 6 commits intodocker-library:masterfrom
tianon merged 6 commits intodocker-library:masterfrom
Conversation
l3ender
force-pushed
the
liberty-feature-config
branch
from
c3e608b to
e00a8d4
Compare
Member
arthurdm
reviewed
Jan 21, 2021
Co-authored-by: Arthur De Magalhaes <arthurdm@ca.ibm.com>
Member
|
@arthurdm PTAL - this LGTY? 🙏 |
arthurdm
reviewed
Feb 1, 2021
arthurdm
reviewed
Feb 1, 2021
Contributor
Co-authored-by: Arthur De Magalhaes <arthurdm@ca.ibm.com>
…fig' into liberty-feature-config
Contributor
Author
|
Thanks for the review and suggestions, @arthurdm. I've made the updates, please take a look! My apologies for the slow response. |
Contributor
|
thanks @l3ender! LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects the documentation for how openliberty feature configuration takes place. The documentation incorrectly states using the wrong script file in a Dockerfile for feature download/configuration during image build.
feature.shis the script used for installing features specified in aserver.xmlfile, whileconfigure.shis used for configuring the server's runtime.See openliberty readme for example.