Skip to content

Update docs for PHP Opcache use #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yosifkit merged 7 commits into from
May 22, 2020
Merged

Update docs for PHP Opcache use #1717

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c6d700e
Update docs for PHP Opcache use
jandom May 14, 2020
67d28a7
Revert "Update docs for PHP Opcache use"
jandom May 14, 2020
b6ae896
Update content.md
jandom May 14, 2020
06201b0
Run markdownfmt
jandom May 14, 2020
f003ba2
Point to further docs on opcache.ini
jandom May 15, 2020
aa8e3e3
Make the Opcache mention even more concise
jandom May 21, 2020
e36656d
Fix mkdownformat
jandom May 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions php/content.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,6 @@ FROM %%IMAGE%%:7.4-fpm-alpine

# Use the default production configuration
RUN mv "$PHP_INI_DIR/php.ini-production" "$PHP_INI_DIR/php.ini"

# Override with custom opcache settings
COPY config/opcache.ini $PHP_INI_DIR/conf.d/
Copy link
Contributor

@jaylinski jaylinski Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yosifkit Why was this removed?

The conf.d-directory is a custom scan-dir, so it is not duplicating common PHP documentation.
https://github.com/docker-library/php/blob/master/7.4/alpine3.12/fpm/Dockerfile#L125

Without this info it is kind of hard to know were to put custom config files, that's why the info was there.

Copy link
Member

@tianon tianon Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See a few lines up:

The default config can be customized by copying configuration files into the $PHP_INI_DIR/conf.d/ directory.

Copy link
Contributor

@jaylinski jaylinski Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint! (I must be blind 🤦‍♂️)

```

In many production environments, it is also recommended to (build and) enable the PHP core OPcache extension for performance. See [the upstream OPcache documentation](https://www.php.net/manual/en/book.opcache.php) for more details.