Conversation
9 tasks
9 tasks
tianon
reviewed
Mar 26, 2021
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
A few notes -- notably, using %%IMAGE%% instead of hitch will ensure that pages for images like amd64/hitch will appropriately shift to the specific architecture image name.
It might also be good to use something like %%IMAGE%%:1 or %%IMAGE%%:1.7 to encourage users to use something more specific than :latest, but that's entirely your call.
Co-authored-by: Tianon Gravi <admwiggin@gmail.com> Co-authored-by: guillaume quintard <gquintard@users.noreply.github.com>
yosifkit
approved these changes
Mar 29, 2021
tianon
reviewed
Apr 2, 2021
|
|
||
| ## Connecting to the backend | ||
|
|
||
| By default Hitch will connect to the backend using `localhost:8843` using the [PROXY protocol](https://github.com/varnish/hitch/blob/master/docs/proxy-protocol.md). If your backend server *PROXY*, the two will be able to talk together and backend will be able to expose the true client IP. |
Member
There was a problem hiding this comment.
If your backend server PROXY, the two ...
This feels like there's a word missing -- maybe "implements"? 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a companion PR to docker-library/official-images#8674