Conversation
yosifkit
requested changes
Apr 24, 2018
Member
yosifkit
left a comment
yosifkit
left a comment
There was a problem hiding this comment.
Just a couple comments and some markdown formatting issues in Travis: https://travis-ci.org/docker-library/docs/builds/370455489#L387-L434
matomo/content.md
Outdated
|
|
||
| ## Docker-composer examples and log import instructions | ||
|
|
||
| A minimal set-up using docker-compose is available in the [.examples folder](.examples/docker-compose.yml), a more complete [example can be found at IndieHosters/piwik](https://github.com/libresh/compose-matomo/blob/master/docker-compose.yml). |
Member
There was a problem hiding this comment.
broken link: .examples/docker-compose.yml. Perhaps you could use %%GITHUB-REPO%%/blob/master/.examples/docker-compose.yml.
It looks like that compose file could use an update to matomo on the image name as well as the IndieHosters link text
matomo/content.md
Outdated
|
|
||
| Then you can continue the installation with the super user. | ||
|
|
||
| ## Docker-composer examples and log import instructions |
Contributor
Author
|
@yosifkit thanks for feedback, I addressed your comments! |
pierreozoux
force-pushed
the
matomo
branch
5 times, most recently
from
816db97 to
a06d693
Compare
Contributor
Author
|
Ok, fixed all the errors, there is one remaining, but I don't get it: Thanks for helping :) |
yosifkit
approved these changes
Apr 25, 2018
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and deprecate piwik