Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apt-transport-https package #56

Closed
wants to merge 1 commit into from
Closed

Add apt-transport-https package #56

wants to merge 1 commit into from

Conversation

Pamplemousse
Copy link

... to allow https urls in sources lists.

Fixes #55 .

... to allow ```https``` urls in sources lists.
@Pamplemousse
Copy link
Author

Hey @tianon, @yosifkit,

Any feedback or chances of seeing this being merge?

Cheers,

@yosifkit
Copy link
Member

My initial reaction is "unlikely" to be merged. My opinion is that since https isn't used on the base mirrors, it shouldn't be added until necessary. It does not increase trust in the provider of the packages, but does hide metadata from snooping 3rd parties. Users generally know that when they add an apt repo with https they also need to install apt-transport-https.

I would rather see this as a default package at the distribution level and all apt repos to be moved to https.

cc @tianon

@tianon
Copy link
Member

tianon commented Jan 18, 2017

Yeah, I definitely agree that this doesn't seem like something in the spirit of buildpack-deps: (from https://hub.docker.com/_/buildpack-deps/)

The main tags of this image are the full batteries-included approach. With them, a majority of arbitrary gem install / npm install / pip install should be successful without additional header/development packages.

I don't think there are any/many gem/npm/pip packages which pull in APT packages themselves. 😕

@Pamplemousse
Copy link
Author

Ok, I understand your points.

You may want to close #55 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants