This repository was archived by the owner on Dec 13, 2018. It is now read-only.
fix some cgroups issues #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If cgroup patch doesn't exist, there is no point we do the Set. Signed-off-by: Qiang Huang <[email protected]>
d.path() should be used to get the real cgroup path, for temp path, we can just create one. Signed-off-by: Qiang Huang <[email protected]>
Contributor
There was a problem hiding this comment.
Nice catch :) I've been meaning to const all these paths and use those consts.
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
Contributor
|
Went to go fix the regression in #337 (essentially making "blkio" required) and found that this PR already did so. 👍 ❤️ 😍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d.path(), so we can really getIsNotFounderror and skipSet.filepath.Join()instead ofd.path().