This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Validation for user namespace in the config. #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice. Shouldn't we also check that there is no mappings in config too? Like we check for network namespace. |
Signed-off-by: Mrunal Patel <[email protected]>
mrunalp
force-pushed
the
userns_check
branch
from
7e0be4d to
f34b3b7
Compare
Contributor
Author
Contributor
|
LGTM, thanks |
Contributor
There was a problem hiding this comment.
should we check if there's any other errors here too i.e. err != nil ?
Contributor
Author
There was a problem hiding this comment.
I think it should be okay not to check for anything else here.
Contributor
|
LGTM |
vmarmol
added a commit
that referenced
this pull request
Feb 19, 2015
Validation for user namespace in the config.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mrunal Patel [email protected]