Add config generation for simple user namespace testing. #379
Conversation
nsinit/config.go
Outdated
There was a problem hiding this comment.
Is this meant to be an int32? This is undefined for them (shifting word size).
There was a problem hiding this comment.
Yeah, want to set it to 2^32. Seems to be working but if it is undefined then need to change this. Thanks.
There was a problem hiding this comment.
if we cast the 1 as an int64 it should be fine :)
There was a problem hiding this comment.
Are you suggesting?
maxUid := int(int64(1) << 32)
There was a problem hiding this comment.
Ah, well 2^32 is not a valid integer (int32). The largest unsigned integer is 2^32 -1. Should this be max unsigned int or max signed int? (both int32)
There was a problem hiding this comment.
It is defined as unsigned uint32 in linux but is represented as int in golang.
Signed-off-by: Mrunal Patel <[email protected]>
mrunalp
force-pushed
the
userns_config_gen
branch
from
c202c1b to
cacc153
Compare
|
Updated to use math.MaxInt32. |
|
LGTM |
Add config generation for simple user namespace testing.
2 participants
Signed-off-by: Mrunal Patel [email protected]