Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Conversation

@LK4D4
Copy link
Contributor

@LK4D4 LK4D4 commented Feb 12, 2015

This should fix problem with hairpin on EL6. I have no EL6 to try though.
/cc @phemmer

@LK4D4 LK4D4 added the in dev label Feb 12, 2015
@phemmer
Copy link
Contributor

phemmer commented Feb 12, 2015

I just spun up a VM last time when I was digging into the issue. I can again, but someone with real world usage might be better.

@LK4D4
Copy link
Contributor Author

LK4D4 commented Feb 12, 2015

Actually I think this can be tested with bridge command from iproute2. Same netlink messages will be sent.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 4 here is IFLA_BRPORT_MODE, right? If so, could we define a constant for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, of course.

Signed-off-by: Alexander Morozov <[email protected]>
@LK4D4
Copy link
Contributor Author

LK4D4 commented Feb 13, 2015

@mrunalp I've added constant.

@mrunalp
Copy link
Contributor

mrunalp commented Feb 13, 2015

@LK4D4 thanks, I will test this out today.

@mrunalp
Copy link
Contributor

mrunalp commented Feb 13, 2015

LGTM

1 similar comment
@crosbymichael
Copy link
Contributor

LGTM

crosbymichael added a commit that referenced this pull request Feb 13, 2015
@crosbymichael crosbymichael merged commit 3f35b26 into docker-archive:master Feb 13, 2015
@LK4D4 LK4D4 deleted the netlink_hairpin_support branch February 13, 2015 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants