This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Add systemd support cpu.cfs_quota_us and cpu.cfs_period_us #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolljt0725
force-pushed
the
add_support_cpu_cfs_quota
branch
from
d5f2cc6 to
51c5e62
Compare
cgroups/systemd/apply_systemd.go
Outdated
Contributor
There was a problem hiding this comment.
where is CpuPeriod? We should support both of them.
coolljt0725
force-pushed
the
add_support_cpu_cfs_quota
branch
from
51c5e62 to
4278498
Compare
coolljt0725
changed the title
Contributor
Author
|
update , add support cpu.cfs_period_us |
coolljt0725
force-pushed
the
add_support_cpu_cfs_quota
branch
from
4278498 to
2907333
Compare
cgroups/systemd/apply_systemd.go
Outdated
Contributor
There was a problem hiding this comment.
I think it makes sense to have a single function for a single cgroup sub-system.
Signed-off-by: Lei Jitang <[email protected]>
coolljt0725
force-pushed
the
add_support_cpu_cfs_quota
branch
from
2907333 to
29f5cb6
Compare
Contributor
Author
|
update as @mrunalp suggestion, have a single function for cpu sub-system |
Contributor
Author
|
ping @mrunalp |
Contributor
|
LGTM |
Contributor
There was a problem hiding this comment.
I think this is not a TODO.
Contributor
There was a problem hiding this comment.
This is still true that native systemd API doesn't support period and quota, right? We are using the filesystem path directly.
Contributor
There was a problem hiding this comment.
Yes, I think the comment is accurate.
Contributor
|
LGTM |
mrunalp
pushed a commit
that referenced
this pull request
Feb 17, 2015
Add systemd support cpu.cfs_quota_us and cpu.cfs_period_us
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lei Jitang [email protected]
fs.Applysupport setcpu.cfs_quota_us, butsystemd.Applydon't. This patch add systemd supportcpu.cfs_quota_us.