This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Resurrect hairpin NAT #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to support being able to DNAT/MASQ traffic from a container back into itself (moby/moby#4442) Docker-DCO-1.1-Signed-off-by: Patrick Hemmer <[email protected]> (github: phemmer)
Contributor
|
LGTM |
Contributor
|
LGTM |
network/types.go
Outdated
Contributor
There was a problem hiding this comment.
Actually that thing not called HairpinNAT. It is rather HairpinMode or just Hairpin
icecrime
force-pushed
the
hairpin-nat
branch
from
fba5679 to
ab06b3c
Compare
Author
|
Renamed |
Offer the ability to enable hairpin NAT on a per network basis, while keeping it disable by default as it is unsupported by older kernel. Signed-off-by: Arnaud Porterie <[email protected]>
icecrime
force-pushed
the
hairpin-nat
branch
from
ab06b3c to
190e50b
Compare
Author
|
Renamed |
Contributor
|
Justification for name -- http://lwn.net/Articles/347344/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're throwing a new attempt at removing the userland proxy from Docker. The blocking issue we discovered last time was that hairpin NAT was not available on some systems (see moby/moby#9134).
This PR reintroduces @phemmer work from #62 and adds the ability to enable Hairpin NAT on a per-network basis using the
Network.HairpinNATflag (disabled by default).