This repository was archived by the owner on Dec 13, 2018. It is now read-only.
add spec for exec a new process inside a container #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
document desired execin process behavior for v1 container specification Docker-DCO-1.1-Signed-off-by: Daniel, Dao Quang Minh <[email protected]> (github: dqminh)
SPEC.md
Outdated
Contributor
There was a problem hiding this comment.
"contained" or "accessible" from within the container?
Docker-DCO-1.1-Signed-off-by: Daniel, Dao Quang Minh <[email protected]> (github: dqminh)
also document that the executor will only try to remove all the children in a best-effort way. Docker-DCO-1.1-Signed-off-by: Daniel, Dao Quang Minh <[email protected]> (github: dqminh)
Contributor
Author
Contributor
|
LGTM |
Contributor
There was a problem hiding this comment.
Is PID 1 the parent process for the exec processes? Also mention exec cleanup when PID 1 dies.
Contributor
Author
There was a problem hiding this comment.
No, PID 1 is the container's main process. The parent process of the exec process is nsenter-exec
Contributor
|
LGTM |
Contributor
|
I think this is good as is. We can adjust it as we change exec behavior later. LGTM, merging. |
rjnagal
added a commit
that referenced
this pull request
Dec 12, 2014
add spec for exec a new process inside a container
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to create a spec for execin process behavior for v1 container specification
Relevant to #286
@crosbymichael @vishh @rjnagal feel free to take this over and change it if i'm missing somethings.