Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Conversation

@dqminh
Copy link
Contributor

@dqminh dqminh commented Dec 10, 2014

when the test binary starts, it detects whether it should run the container
initialization code or the execin initialization code based on the suppplied
arguments. The execin initialization code is taken from docker.

also added a sample test for execin process.

Docker-DCO-1.1-Signed-off-by: Daniel, Dao Quang Minh [email protected] (github: dqminh)

when the test binary starts, it detects whether it should run the container
initialization code or the execin initialization code based on the suppplied
arguments. The execin initialization code is taken from docker.

also added a sample test for execin process.

Docker-DCO-1.1-Signed-off-by: Daniel, Dao Quang Minh <[email protected]> (github: dqminh)
@rjnagal
Copy link
Contributor

rjnagal commented Dec 10, 2014

LGTM.
Thanks for the tests. I am not sure if there's any better way to share docker code for calling exec, but its nice to have a test in libcontainer repo rather than relying on docker integration tests.

@crosbymichael
Copy link
Contributor

@dqminh thanks for all your help!

@crosbymichael
Copy link
Contributor

LGTM

crosbymichael added a commit that referenced this pull request Dec 10, 2014
add support for testing execin
@crosbymichael crosbymichael merged commit 0d04027 into docker-archive:master Dec 10, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants