This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Add support for setting rlimit for contianer #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
drone failed. Needs gofmt. |
cpuguy83
force-pushed
the
add_rlimit_support
branch
from
c64aa42 to
1cec3e6
Compare
Contributor
Author
|
Sorry, fixed. |
config.go
Outdated
Contributor
There was a problem hiding this comment.
nit: spelling Cur out to Current is better readability karma :)
Contributor
Author
There was a problem hiding this comment.
Agreed... and possibly set it to "Hard" and "Soft" instead.
lmk if that's what we want.
Contributor
There was a problem hiding this comment.
Hard and Soft sounds even better.
Contributor
|
just a couple of nits. LGTM. |
cpuguy83
force-pushed
the
add_rlimit_support
branch
2 times, most recently
from
1c55978 to
27a6d7a
Compare
config.go
Outdated
Contributor
There was a problem hiding this comment.
I would not have a pointer here for these values, they are small. Rlimits []Rlimit
Adds a new item to the config struct []*Rlimit Rlimit takes a type (ie, syscall.RLIMIT_NOFILE) and the hard/soft limit (As max/cur) Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
add_rlimit_support
branch
from
27a6d7a to
e6cc8fc
Compare
Contributor
Author
|
Updated - Max/Soft set, using non-pointer for []Rlimit |
Contributor
|
LGTM |
Contributor
|
LGTM. |
crosbymichael
added a commit
that referenced
this pull request
Nov 26, 2014
Add support for setting rlimit for contianer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new item to the config struct []*Rlimit
Rlimit takes a type (ie, syscall.RLIMIT_NOFILE) and the hard/soft limit
(As max/cur)
My naive shot at adding support for setting rlimits.