Skip to content
This repository has been archived by the owner on Sep 12, 2018. It is now read-only.

fix registry._setup_database.lock remove issue and rollback the session after UNIQUE constraint failed exception #917

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docker_registry/lib/index/db.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,11 @@ def _generate_index(self, session):
session.add(Version(id=self.version))
for repository in self._walk_storage(store=store):
session.add(Repository(**repository))
session.commit()
try:
session.commit()
except Exception as e:
logger.exception(str(e))
session.rollback()

@retry
def _handle_repository_created(
Expand Down
3 changes: 2 additions & 1 deletion docker_registry/toolkit.py
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,8 @@ def wrapper(*args, **kwargs):
try:
result = f(*args, **kwargs)
finally:
os.remove(lock_path)
if os.path.exists(lock_path):
os.remove(lock_path)
return result
return wrapper

Expand Down