Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

Conversation

@YarekTyshchenko
Copy link

@YarekTyshchenko YarekTyshchenko commented Feb 9, 2018

This seems to be related to PR moby/moby#30321, which actually has two
underlying issues:

  1. After starting new container, the old container, being in shutdown phase, still receives new connections.
  2. After issuing container shutdown, existing connections are cut, instead
    of waiting for the container to cut them off as part of its shutdown.

Problem 1 seems to be fixed in 18.02, but problem 2 remains.

This patch seems to honour the stop_grace_period defined in the compose file.

Disclaimer:
I seem to have assembled this patch from two other patches that I found in the above PR thread. One is:
hjdr4/libnetwork@234cdaa
and another one that I can't find (one that gets the endpoint from the store). However, testing it
with https://github.com/YarekTyshchenko/docker-rolling-upgrade-test/tree/streams seems to work fine.

@GordonTheTurtle
Copy link
Contributor

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "18.02-small-patch" [email protected]:awin/docker-ce.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354015536
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@YarekTyshchenko YarekTyshchenko changed the base branch from master to 18.02 February 9, 2018 14:10
@YarekTyshchenko YarekTyshchenko changed the base branch from 18.02 to master February 9, 2018 15:05
Signed-off-by: Yarek Tyshchenko <[email protected]>
@thaJeztah
Copy link
Member

Thanks for contributing, however, the files that are updated in this PR are vendored files, and should be changed upstream (in docker/libnetwork), and re-vendored in upstream Moby/moby first.

Based on priority/urgency, fixes can be backported from moby/moby after that.

I'll close this PR, but feel free to continue the conversation

@thaJeztah thaJeztah closed this Feb 13, 2018
@YarekTyshchenko
Copy link
Author

Yes, @thaJeztah, happy for this to be closed. As @abhi pointed out that the issue is confirmed, but you have chosen to go down a different path, in the corresponding commit in libnetwork: moby/libnetwork#2074 (comment)

I look forward to seeing what you all come up with! ❤️

docker-jenkins pushed a commit that referenced this pull request Nov 1, 2019
[19.03] Windows: disable flaky test TestStartReturnCorrectExitCode
Upstream-commit: 35913e58c2089c2d19eb02b611fc289d1c56f113
Component: engine
docker-jenkins pushed a commit that referenced this pull request Jan 22, 2020
…2.15

[19.03 backport] Update Golang 1.12.15
Upstream-commit: 57fdcf8d98f55850be59c45f342fcc42f5f424f9
Component: packaging
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants