This repository was archived by the owner on Oct 13, 2023. It is now read-only.
Patch to fix libnetwork cutting off streaming connections on update #419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be related to PR moby/moby#30321, which actually has two
underlying issues:
of waiting for the container to cut them off as part of its shutdown.
Problem 1 seems to be fixed in 18.02, but problem 2 remains.
This patch seems to honour the
stop_grace_perioddefined in the compose file.Disclaimer:
I seem to have assembled this patch from two other patches that I found in the above PR thread. One is:
hjdr4/libnetwork@234cdaa
and another one that I can't find (one that gets the endpoint from the store). However, testing it
with https://github.com/YarekTyshchenko/docker-rolling-upgrade-test/tree/streams seems to work fine.