This repository was archived by the owner on Jul 18, 2025. It is now read-only.
keep machine URL consistent in machine config and machine env#649
Merged
ehazlett merged 1 commit intodocker-archive-public:masterfrom Feb 27, 2015
Merged
Conversation
shawnzhu
force-pushed
the
no-escape-quote
branch
from
7df1d43 to
0d0707f
Compare
Contributor
|
LGTM |
Contributor
|
/cc @nathanleclaire |
There was a problem hiding this comment.
Should these type of "undo" things be in some defers so that when the t.Fatal's are run we still reset the env?
Contributor
There was a problem hiding this comment.
absolutely +1 -- thx!
@shawnzhu I will do a follow up PR after this is merged to add all of the defer cleanup.
Author
Signed-off-by: Ke Zhu <kzhu@us.ibm.com>
shawnzhu
force-pushed
the
no-escape-quote
branch
from
0d0707f to
bc91ba8
Compare
Contributor
|
Arg, I could have sworn there was a reason I implemented it this way, but unfortunately I can't remember why. So I'm hoping it was just aesthetics - LGTM |
ehazlett
added a commit
that referenced
this pull request
Feb 27, 2015
keep machine URL consistent in machine config and machine env
Contributor
|
thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now it output double-quoted string value for docker host only when performing command
machine config:Which works for
dockercommand only because of moby/moby#6147 but not for other project like drone/drone which usescodegangsta/clithat does not trim quotes for string flag all the time.This PR will enable scenario like command
drone build $(docker-machine config)on OS X, which doesn't work util it removes the double quotes of docker host from commandmachine config. (notice that it doesn't use double quotes inmachine envtoo)