feat(web): adopt browser routing for cleaner URIs #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevapple
force-pushed
the
browser-router
branch
from
6123d35 to
be07a8d
Compare
|
Mark as draft until backward compatibility is addressed. |
|
Thanks for the changes @stevapple, we just had a 'facelift' of the frontend page of the UI #907, would you mind rebasing onto |
stevapple
force-pushed
the
browser-router
branch
from
7413762 to
7726940
Compare
Done |
stevapple
force-pushed
the
browser-router
branch
from
7726940 to
6595af5
Compare
stevapple
force-pushed
the
browser-router
branch
from
6595af5 to
ec0bdea
Compare
stevapple
force-pushed
the
browser-router
branch
from
ab59083 to
91548d3
Compare
|
@randombenj @fliiiix bother for a second review? |
randombenj
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
docatto use browser history for routing, for simpler implementation and cleaner URIs.BREAKING:
docandapiare no longer valid project names.Before:
After:
Old-styled URIs will be automatically rewritten to newer ones upon loading.