Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Optimize Docker build #640

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix: Optimize Docker build #640

merged 1 commit into from
Oct 3, 2023

Conversation

reglim
Copy link
Contributor

@reglim reglim commented Oct 3, 2023

I switched from using node:20.5 to node:20-slim, saving a lot of bandwidth when it has to be pulled. I also moved the yarn install up so it only installs the dependencies when the package.json or yarn.lock files changed.

Cuts build time about 15s when developing in frontend.

fixes: #639

I switched from using node:20.5 to node:20-slim, saving a lot of bandwidth when it has to be pulled.
I also moved the yarn install up so it only installs the dependencies when the package.json or yarn.lock files changed.

fixes: #639
Copy link
Member

@randombenj randombenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@reglim reglim merged commit bee37af into main Oct 3, 2023
@reglim reglim deleted the fix/639-optimize-docker-build branch October 3, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize Dockerfile
2 participants