Fix: Navigate Back not working on docs page, navigate forward is currently not possible #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reglim
force-pushed
the
fix/593-history-not-working-on-docs-page
branch
from
699025a to
15dee9a
Compare
Navigate forward is currently not possible. fixes: #593
reglim
force-pushed
the
fix/593-history-not-working-on-docs-page
branch
from
15dee9a to
1fc90d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't get navigate forward to work, because we have a huge problem with event handlers pushing urls even when we go back a page, so when you click back you can't click forward again. I discussed it with @randombenj and we decided to leave it for the moment.
How I did it was I added an event listener for the
popstateevent that is triggered when the user clicks a navigation button, and triggered back again when it fired, because clicking back once didn't work for unknown reasons.