Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/589-migrate-to-vite-and-vitest #590

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Improvement/589-migrate-to-vite-and-vitest #590

merged 2 commits into from
Aug 30, 2023

Conversation

reglim
Copy link
Contributor

@reglim reglim commented Aug 30, 2023 •
edited
Loading

See this guide: https://dev.to/henriquejensen/migrating-from-create-react-app-to-vite-a-quick-and-easy-guide-5e72

Building with react-scripts: 44s
Building with vite: 12s

Fixes: #589

@reglim reglim requested review from fliiiix and randombenj August 30, 2023 09:49
@reglim reglim mentioned this pull request Aug 30, 2023
Merged
@fliiiix
Copy link
Member

fliiiix commented Aug 30, 2023

lgtm and faster is more good

reglim added a commit that referenced this pull request Aug 30, 2023
@reglim
Dependency cleanup
c7f0cf7 
Done with npm-check and poetry update
Depends on: #590
Also fixes: #588, because react-scripts is no longer used
@reglim reglim merged commit d4778dd into main Aug 30, 2023
@reglim reglim deleted the improvement/589-migrate-to-vite branch August 30, 2023 10:11
reglim added a commit that referenced this pull request Aug 30, 2023
@reglim
Dependency cleanup
7a274b6 
Done with npm-check and poetry update
Depends on: #590
Also fixes: #588, because react-scripts is no longer used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fliiiix fliiiix Awaiting requested review from fliiiix

@randombenj randombenj Awaiting requested review from randombenj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to Vite
2 participants
@reglim @fliiiix